Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agent, resolve #4636]: Add linting support to file editor #4637

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

xingyaoww
Copy link
Contributor

  • Import DefaultLinter and initialize in constructor
  • Add _run_linting helper method to check changes
  • Run linting after str_replace and insert operations
  • Show linting results in edit output

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions


Link of any specific issues this addresses

openhands-agent and others added 6 commits October 30, 2024 16:43
- Import DefaultLinter and initialize in constructor
- Add _run_linting helper method to check changes
- Run linting after str_replace and insert operations
- Show linting results in edit output
- Test str_replace with linting error
- Test insert with linting error
- Verify error messages are reported correctly
@xingyaoww xingyaoww marked this pull request as ready for review October 31, 2024 18:32
@xingyaoww xingyaoww marked this pull request as draft October 31, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants