Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #4629: [Bug]: Replace claude-3-5-sonnet-20240620 with claude-3-5-sonnet-20241022 #4631

Merged
merged 8 commits into from
Oct 30, 2024

Conversation

openhands-agent
Copy link
Contributor

This pull request fixes #4629.

The issue has been successfully resolved. The PR updates all instances of "claude-3-5-sonnet-20240620" to "claude-3-5-sonnet-20241022" across documentation files (including translations), frontend files, and Python files, while properly preserving locations where both model versions need to be listed together (such as in CACHE_PROMPT_SUPPORTED_MODELS and VERIFIED_ANTHROPIC_MODELS).

Automatic fix generated by OpenHands 🙌

@neubig
Copy link
Contributor

neubig commented Oct 30, 2024

It's a bit weird, I don't know why large sections of documentation ended up getting deleted? It doesn't seem that the agent actually did that...

@tofarr
Copy link
Collaborator

tofarr commented Oct 30, 2024

It's a bit weird, I don't know why large sections of documentation ended up getting deleted? It doesn't seem that the agent actually did that...

Could this be the result of a merge error? It looks like some of those changes were only added yesterday? https://github.com/All-Hands-AI/OpenHands/blame/main/docs/i18n/fr/docusaurus-plugin-content-docs/current/usage/how-to/headless-mode.md

Maybe we need to look at how the agent does merges

@neubig neubig enabled auto-merge (squash) October 30, 2024 15:58
@@ -1,6 +1,6 @@
// Here are the list of verified models and providers that we know work well with OpenHands.
export const VERIFIED_PROVIDERS = ["openai", "azure", "anthropic"];
export const VERIFIED_MODELS = ["gpt-4o", "claude-3-5-sonnet-20240620"];
export const VERIFIED_MODELS = ["gpt-4o", "claude-3-5-sonnet-20241022"];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably keep the old Sonnet here, if this is the list of verified models that we know work well... it did, didn't it? 🤔

Copy link
Contributor

@xingyaoww xingyaoww Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree here - but the new sonnet is WAY better i guess

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also make sense to me that we only put the new sonnet as verified model to encourage ppl using it 😓

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know... We already "recommend" somewhere else, I know we also have in addition a little list where we add models as we verify them to be decent...

Copy link
Collaborator

@enyst enyst Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, these are two different things, at least according to the current documentation. We have:

  • one recommended model - the best
  • verified models - those we know work well enough for a decent experience
  • the rest - all should work (start, run), but we tell people we don't know how well, and don't recommend them...

Does that make sense?

@neubig neubig merged commit 866ba6e into main Oct 30, 2024
15 checks passed
@neubig neubig deleted the openhands-fix-issue-4629-try2 branch October 30, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Replace claude-3-5-sonnet-20240620 with claude-3-5-sonnet-20241022
6 participants