Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Record events sent to WS #4596

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

amanape
Copy link
Member

@amanape amanape commented Oct 28, 2024

End-user friendly description of the problem this fixes or functionality that this introduces
Only events received from the websocket were recorded

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions
Store all events that are sent to the web socket


Link of any specific issues this addresses
Resolves #4592

@amanape amanape requested a review from neubig October 28, 2024 15:19
@amanape amanape self-assigned this Oct 28, 2024
Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch! This would be even better if we could also add a test to make sure that we don't have regressions.

@amanape
Copy link
Member Author

amanape commented Oct 28, 2024

Testing feedback is on my TODO, it will require some effort for now (mocking WS) so I'll push it for sometime soon

@amanape amanape enabled auto-merge (squash) October 28, 2024 15:39
@amanape amanape merged commit 13d101e into main Oct 28, 2024
12 checks passed
@amanape amanape deleted the hotfix/store-sent-events branch October 28, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Share functionality is not displaying user events
2 participants