Fix bug in file switching #4577
Open
+69
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes All-Hands-AI#4576 Add debounce mechanism to handle rapid file switching in the editor. * **frontend/src/context/files.tsx** - Import `debounce` from `lodash`. - Add `debouncedSetSelectedPath` to handle rapid file switching. - Update `value` to use `debouncedSetSelectedPath`. * **frontend/src/components/file-explorer/FileExplorer.tsx** - Import `debounce` from `lodash`. - Add `debouncedSetSelectedPath` to handle rapid file switching. - Update `FileExplorer` to use `debouncedSetSelectedPath`. * **frontend/src/routes/_oh.app._index/route.tsx** - Import `debounce` from `lodash`. - Add `debouncedSetSelectedPath` to handle rapid file switching. - Update `CodeEditor` to use `debouncedSetSelectedPath`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/All-Hands-AI/OpenHands/issues/4576?shareId=XXXX-XXXX-XXXX-XXXX).
* Enable previously skipped tests * Add test for rendering an empty workspace * Add test for uploading files by dragging them to the explorer * Add test for downloading a file * Add test for displaying correct file content when switching files quickly
neubig
requested changes
Oct 27, 2024
There was a problem hiding this comment.
Hey @PierrunoYT , tests are failing could you please fix them and then re-request my review when you're done?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4576
Add debounce mechanism to handle rapid file switching in the editor.
frontend/src/context/files.tsx
debouncefromlodash.debouncedSetSelectedPathto handle rapid file switching.valueto usedebouncedSetSelectedPath.frontend/src/components/file-explorer/FileExplorer.tsx
debouncefromlodash.debouncedSetSelectedPathto handle rapid file switching.FileExplorerto usedebouncedSetSelectedPath.frontend/src/routes/_oh.app._index/route.tsx
debouncefromlodash.debouncedSetSelectedPathto handle rapid file switching.CodeEditorto usedebouncedSetSelectedPath.For more details, open the Copilot Workspace session.