[WIP] Use i18n Keys (2) #4464
Draft
[WIP] Use i18n Keys (2) #4464
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
amanape
reviewed
Oct 18, 2024
There was a problem hiding this comment.
You're on the right path! It would be helpful if you could also update your description to include the files and directories you plan on covering, e.g.,
- modals
- forms
And so on...
This will help sync with @Vaishakh-SM and reduce chances of conflicts
| return ( | ||
| <ModalBody> | ||
| <span className="text-xl leading-6 -tracking-[0.01em] font-semibold"> | ||
| {message || "Loading..."} | ||
| {message || "Loading..." || t(I18nKey.LOADING_PROJECT$LOADING)} |
There was a problem hiding this comment.
Suggested change
| {message || "Loading..." || t(I18nKey.LOADING_PROJECT$LOADING)} | |
| {message || t(I18nKey.LOADING_PROJECT$LOADING)} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Work in progress. Updates interface components to use i18next keys so that the user can view them in different languages. See also this PR
Link of any specific issues this addresses
#4280