Fix: Init browser for ServerRuntime #3156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmartManoj
changed the title
xingyaoww
reviewed
Jul 29, 2024
tests/unit/test_runtime.py
Outdated
| @@ -306,7 +306,9 @@ async def test_simple_browse(temp_dir, box_class): | |||
| runtime = await _load_runtime(temp_dir, box_class) | |||
|
|
|||
| # Test browse | |||
| action_cmd = CmdRunAction(command='python -m http.server 8000 > server.log 2>&1 &') | |||
| action_cmd = CmdRunAction( | |||
| command='$OPENDEVIN_PYTHON_INTERPRETER -m http.server 8000 > server.log 2>&1 &' | |||
There was a problem hiding this comment.
$OPENDEVIN_PYTHON_INTERPRETER may not be available in EventStreamRuntime
There was a problem hiding this comment.
In future? The tests are passed now. Python is only not available in ServerRuntime
There was a problem hiding this comment.
Yes, $OPENDEVIN_PYTHON_INTERPRETER is not available in EventStreamRuntime
and python is not available in ServerRuntime
The mentioned error is solved. The following error will be solved by #3155
|
|
We're doing some cleanup of PRs, and are going to close this one for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
Solves the following one of the two errors from #3128
FAILED tests/unit/test_runtime.py::test_simple_browse[ServerRuntime] - opendevin.core.exceptions.BrowserUnavailableException: Browser environment is not available, please check if has been initialized
Give a summary of what the PR does, explaining any non-trivial design decisions
Added browser tool and used full path for python
Other references