Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加leaderElection,支持多副本高可用部署 #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

silenceper
Copy link

fix #62

@codecov-io
Copy link

codecov-io commented Feb 21, 2020

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   52.58%   52.58%           
=======================================
  Files          24       24           
  Lines        1434     1434           
=======================================
  Hits          754      754           
  Misses        618      618           
  Partials       62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a0b3b8...82ff79b. Read the comment docs.

@ringtail
Copy link
Member

That's really cool!

@ringtail
Copy link
Member

I will review this pr later.

@ringtail
Copy link
Member

ringtail commented Mar 2, 2020

This pr is too large because of vendor changes. Could you split this PR into two commit. One is for the source code changes and the other for the vendor. Thanks!

@silenceper
Copy link
Author

Resubmitted

@zeusro
Copy link
Contributor

zeusro commented Mar 3, 2020

@silenceper 你这个实现,对副本数有要求吗?比如要奇数个不能偶数个之类的

然后就是,主从节点怎么消费 Event 的

@zeusro
Copy link
Contributor

zeusro commented Mar 3, 2020

还有,如果你要配置高可用的话,YAML 文件必须用反亲和度让所有的pod不运行在同一个节点吧?

@silenceper
Copy link
Author

@silenceper 你这个实现,对副本数有要求吗?比如要奇数个不能偶数个之类的

然后就是,主从节点怎么消费 Event 的

没要求,跟你理解的etcd不一样,它实现是一个分布式锁,谁先抢占到就执行,其余的等待,同时工作的只会有一个节点

@zeusro
Copy link
Contributor

zeusro commented Mar 3, 2020

@silenceper 你这个实现,对副本数有要求吗?比如要奇数个不能偶数个之类的
然后就是,主从节点怎么消费 Event 的

没要求,跟你理解的etcd不一样,它实现是一个分布式锁,谁先抢占到就执行,其余的等待,同时工作的只会有一个节点

那可以以replicas: 1运行吗?有些 kubernetes 环境是测试的,只有1节点.

@silenceper
Copy link
Author

可以

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.24%. Comparing base (9a0b3b8) to head (82ff79b).
Report is 191 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   52.58%   53.24%   +0.66%     
==========================================
  Files          24       24              
  Lines        1434     1448      +14     
==========================================
+ Hits          754      771      +17     
+ Misses        618      614       -4     
- Partials       62       63       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

是否支持多副本部署?
5 participants