Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constraint replica within [min,max] while training or scaling #10

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

goodoid
Copy link
Collaborator

@goodoid goodoid commented May 27, 2021

if replica + delta > max or replica + delta < min, fail the job or abort the scaling

@@ -41,7 +41,7 @@ type ScaleInSpec struct {
}

type ToDeleteSpec struct {
Count int `json:"count,omitempty"`
Count int32 `json:"count,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need change this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep same with ScaleOut schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants