Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OGUI-1594] Remove double conversion of grpc error and adapt to usage of errors from web-ui #2713

Merged
merged 7 commits into from
Jan 30, 2025
Merged

[OGUI-1594] Remove double conversion of grpc error and adapt to usage of errors from web-ui #2713

merged 7 commits into from
Jan 30, 2025

Conversation

graduta
Copy link
Member

@graduta graduta commented Jan 8, 2025

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

PR which:

  • removes CustomError Classes from Control codebase and reuses them from web-ui
  • fixes a bug in which EnvironmentService was trying to convert an error from a gRPC error

@graduta graduta requested a review from pepijndik January 8, 2025 13:59
@graduta graduta self-assigned this Jan 8, 2025
@graduta
Merge branch 'dev' of github.com:AliceO2Group/WebUi into bug/COG/OGUI…
c055d77 
…-1594/remove-double-conversion-of-grpc-error
@graduta graduta merged commit 52751c1 into dev Jan 30, 2025
8 of 9 checks passed
@graduta graduta deleted the bug/COG/OGUI-1594/remove-double-conversion-of-grpc-error branch January 30, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepijndik pepijndik pepijndik left review comments

@mariscalromeroalejandro mariscalromeroalejandro mariscalromeroalejandro approved these changes

Assignees

@graduta graduta

Labels
Backend Control
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graduta @pepijndik @mariscalromeroalejandro