Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWGLF] Refactor and Optimize chk892flow.cxx for Improved Readability and Performance #9494

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

BongHwi
Copy link
Collaborator

@BongHwi BongHwi commented Jan 23, 2025

  • Code Cleanup:
    • Removed unnecessary includes (TMath.h, TDatabasePDG.h, TPDGCode.h).
    • Replaced TMath::Abs with standard std::abs for better portability.
    • Updated variable names to follow a consistent naming convention (e.g., DetId to lDetId).
  • Performance Improvements:
    • Introduced the use of std::cos, std::atan2 instead of ROOT-specific functions for efficiency.
    • Optimized event selection by refactoring redundant configurations.
    • Replaced repeated calculations with pre-computed values where applicable.
  • New Features:
    • Added configuration options for rotated background analysis, allowing flexibility in pion rotation settings.
    • Implemented histogram for tracking rotated background angles.
  • Code Style and Readability:
    • Renamed and refactored several methods to improve clarity and consistency (GetCentrality → getCentrality, GetDetId → getlDetId).
    • Applied consistent formatting and spacing for better readability.
    • Improved logging messages for debugging purposes.

@njacazio njacazio merged commit fc6c7e2 into AliceO2Group:master Jan 24, 2025
11 of 12 checks passed
@BongHwi BongHwi deleted the ResoChK892flow branch January 27, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants