-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix injection gap math #1859
Fix injection gap math #1859
Conversation
The change introduced in AliceO2Group#1431 had the side effect that no signal events were present in recent productions using this generator, as for operator precedence one could never satisfy the condition of the if regulating the generation of signal events.
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
Thanks, nice catch! |
You may also take a look at the novel hybrid event generator (see for instance https://github.com/AliceO2Group/AliceO2/blob/dev/run/SimExamples/Hybrid/hybridconfig.json) which allows to pick events from multiple different generator instances in certain sequences. |
* Fix injection gap math The change introduced in #1431 had the side effect that no signal events were present in recent productions using this generator, as for operator precedence one could never satisfy the condition of the if regulating the generation of signal events. * Further simplify the code (cherry picked from commit c23cfd2)
* Fix injection gap math The change introduced in #1431 had the side effect that no signal events were present in recent productions using this generator, as for operator precedence one could never satisfy the condition of the if regulating the generation of signal events. * Further simplify the code (cherry picked from commit c23cfd2)
* Fix injection gap math The change introduced in #1431 had the side effect that no signal events were present in recent productions using this generator, as for operator precedence one could never satisfy the condition of the if regulating the generation of signal events. * Further simplify the code (cherry picked from commit c23cfd2)
The change introduced in #1431 had the side effect that no signal events were present in recent productions using this generator, as for operator precedence one could never satisfy the condition of the if regulating the generation of signal events.
@njacazio @ddobrigk