ZDC: combine local and remote QC configuration into a single file #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion file Two new JIT workflows are added, for FLP and remote QC node, which allow to run the local and remote QC tasks from a single configuration file
teo
approved these changes
Oct 14, 2024
Barthelemy
approved these changes
Oct 14, 2024
|
@Barthelemy @aferrero2707 this has now been merged but it's not yet in production. |
vascobarroso
pushed a commit
that referenced
this pull request
Oct 15, 2024
…tion file (#667) Two new JIT workflows are added, for FLP and remote QC node, which allow to run the local and remote QC tasks from a single configuration file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current ZDC workflows and QC configuration, the ZDC FLP is not only running the raw QC task, but also the corresponding checker and post-processing task.
While this is not forbidden, it would be preferable to move the checker and post-processing to the remote QC node, and only leave the task on the FLP.
Moreover, given that ZDC has only one FLP node, it seems more practical to combine all tasks in a single multi-node configuration file, to avoid duplicating parts of the configuration in multiple files.
Two new workflows, one local and one remote, are cloned from the original ones:
zdc-full-qcmn-localfromzdc-raw-qczdc-full-qcmn-remotefromzdc-rec-epnCompared to the original workflows, the new ones have the following changes:
--local --host flpare added to theo2-qccommand in the FLP workflow, to prevent the execution of the checker and post-processing tasksIn addition, I have appended the
run_typeandbeam_typeparameters to the apricot URLs in the new workflows, to allow extra flexibility in the QC configuration if needed.More details are given in https://its.cern.ch/jira/browse/OCTRL-941