[core] Make sure end of trigger is before end of run #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopers8
commented
Nov 24, 2023
Comment on lines
+458
to
+472
|
|
||
| trgEndTimeMsUint, _ := strconv.ParseUint(grp.trgEndTimeMs, 10, 32) | ||
| o2EndTimeMsUint, _ := strconv.ParseUint(grp.runEndTimeMs, 10, 32) | ||
| if trgEndTimeMsUint == 0 { | ||
| log.WithField("call", "RunStop"). | ||
| WithField("partition", envId). | ||
| WithField("level", infologger.IL_Ops). | ||
| Error("End of trigger time will be missing in the CCDB GRPECS. Please create a log entry in BK and tag PDP") | ||
| } | ||
| if trgEndTimeMsUint > o2EndTimeMsUint { | ||
| log.WithField("call", "RunStop"). | ||
| WithField("partition", envId). | ||
| WithField("level", infologger.IL_Ops). | ||
| Errorf("End of trigger time will be later than end of run time (%d > %d) in the CCDB GRPECS. Please create a log entry in BK and tag PDP", trgEndTimeMsUint, o2EndTimeMsUint) | ||
| } |
There was a problem hiding this comment.
@chiarazampolli @shahor02 what do you think of these messages?
I have to test the other fixes yet, so the PR is not ready as a whole.
PDP requires that SOR < SOX < EOX < EOR. To achieve this, setting run_end_time_ms was moved so that there is an opportunity to run CTP run stop hooks before that.
knopers8
changed the title
|
@teo Ready for review it goes with AliceO2Group/ControlWorkflows#624 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.