Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL Analysis: Preliminary changes for Table rewrite #13679

Merged
merged 11 commits into from
Nov 19, 2024

Conversation

aalkin
Copy link
Member

@aalkin aalkin commented Nov 12, 2024

@ktf some of the self-consistent changes extracted from #13664

@aalkin aalkin requested a review from a team as a code owner November 12, 2024 10:12
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for e0a4d7e at 2024-11-12 12:55:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
/sw/slc8_x86-64/O2/13679-slc8_x86-64-local1/include/Framework/AnalysisDataModel.h:36:1: error: incomplete type 'o2::aod::MetadataTrait<o2::soa::Join<o2::soa::Join<o2::aod::TracksExtensionFrom<o2::framework::OriginEnc{5134660}>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::track::CollisionId, o2::aod::track::TrackType, o2::aod::track::X, o2::aod::track::Alpha, o2::aod::track::Y, o2::aod::track::Z, o2::aod::track::Snp, o2::aod::track::Tgl, o2::aod::track::Signed1Pt, o2::aod::track::IsWithinBeamPipe<o2::aod::track::X>, o2::aod::track::Px<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Py<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Pz<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::PVector<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha, o2::aod::track::Tgl>, o2::aod::track::Energy<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Rapidity<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Sign<o2::aod::track::Signed1Pt>, o2::soa::Marker<1> > >, o2::soa::Join<o2::aod::TracksCovExtensionFrom<o2::framework::OriginEnc{5134660}>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::track::SigmaY, o2::aod::track::SigmaZ, o2::aod::track::SigmaSnp, o2::aod::track::SigmaTgl, o2::aod::track::Sigma1Pt, o2::aod::track::RhoZY, o2::aod::track::RhoSnpY, o2::aod::track::RhoSnpZ, o2::aod::track::RhoTglY, o2::aod::track::RhoTglZ, o2::aod::track::RhoTglSnp, o2::aod::track::Rho1PtY, o2::aod::track::Rho1PtZ, o2::aod::track::Rho1PtSnp, o2::aod::track::Rho1PtTgl, o2::soa::Marker<1> > > > >::metadata' {aka 'void'} used in nested name specifier
/sw/SOURCES/O2Physics/13679-slc8_x86-64/0/Tutorials/src/filters.cxx:37:1: error: 'constexpr' call flows off the end of the function
/sw/SOURCES/O2Physics/13679-slc8_x86-64/0/Tutorials/src/filters.cxx:37:1: error: 'constexpr' call flows off the end of the function
/sw/slc8_x86-64/O2/13679-slc8_x86-64-local1/include/Framework/Pack.h:57:7: error: invalid use of incomplete type 'struct o2::framework::pack_element<18446744073709551615, o2::framework::pack<> >'
ninja: build stopped: subcommand failed.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/3ee0231744b0425c0218e737fbcc3c582fb914c1/slc8_x86-64/o2checkcode/1.0-local443/etc/modulefiles
++ cat
--

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Nov 12, 2024

Error while checking build/O2/fullCI for c4b016f at 2024-11-12 18:16:

## sw/BUILD/O2Physics-latest/log
/sw/slc8_x86-64/O2/13679-slc8_x86-64-local1/include/Framework/AnalysisDataModel.h:36:1: error: incomplete type 'o2::aod::MetadataTrait<o2::soa::Join<o2::soa::Join<o2::aod::TracksExtensionFrom<o2::framework::OriginEnc{5134660}>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::soa::Index<0, -1>, o2::aod::track::CollisionId, o2::aod::track::TrackType, o2::aod::track::X, o2::aod::track::Alpha, o2::aod::track::Y, o2::aod::track::Z, o2::aod::track::Snp, o2::aod::track::Tgl, o2::aod::track::Signed1Pt, o2::aod::track::IsWithinBeamPipe<o2::aod::track::X>, o2::aod::track::Px<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Py<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha>, o2::aod::track::Pz<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::PVector<o2::aod::track::Signed1Pt, o2::aod::track::Snp, o2::aod::track::Alpha, o2::aod::track::Tgl>, o2::aod::track::Energy<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Rapidity<o2::aod::track::Signed1Pt, o2::aod::track::Tgl>, o2::aod::track::Sign<o2::aod::track::Signed1Pt>, o2::soa::Marker<1> > >, o2::soa::Join<o2::aod::TracksCovExtensionFrom<o2::framework::OriginEnc{5134660}>, o2::soa::Table<o2::framework::OriginEnc{4476737}, o2::aod::track::SigmaY, o2::aod::track::SigmaZ, o2::aod::track::SigmaSnp, o2::aod::track::SigmaTgl, o2::aod::track::Sigma1Pt, o2::aod::track::RhoZY, o2::aod::track::RhoSnpY, o2::aod::track::RhoSnpZ, o2::aod::track::RhoTglY, o2::aod::track::RhoTglZ, o2::aod::track::RhoTglSnp, o2::aod::track::Rho1PtY, o2::aod::track::Rho1PtZ, o2::aod::track::Rho1PtSnp, o2::aod::track::Rho1PtTgl, o2::soa::Marker<1> > > > >::metadata' {aka 'void'} used in nested name specifier
/sw/SOURCES/O2Physics/13679-slc8_x86-64/0/Tutorials/src/filters.cxx:37:1: error: 'constexpr' call flows off the end of the function
/sw/SOURCES/O2Physics/13679-slc8_x86-64/0/Tutorials/src/filters.cxx:37:1: error: 'constexpr' call flows off the end of the function
ninja: build stopped: subcommand failed.

Full log here.

@aalkin aalkin force-pushed the preliminary-changes branch from c4b016f to 765277c Compare November 13, 2024 09:03
@ktf
Copy link
Member

ktf commented Nov 14, 2024

This is fine with me, a few adjustments can be made once we have everything in place, as discussed. I am testing it on hyperloop and then I will merge it.

@ktf ktf merged commit b0b090f into AliceO2Group:dev Nov 19, 2024
12 of 13 checks passed
@ktf
Copy link
Member

ktf commented Nov 19, 2024

Tested on hyperloop as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants