-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get column value by column label in Framework Core ASoA #13498
Get column value by column label in Framework Core ASoA #13498
Conversation
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
Thank you for your investigation. Much appreciated. As a general note, please try to have a smaller contributions if possible, because that will for sure simplify and speedup the review process. |
Please consider the following formatting changes to AliceO2Group#13498
Previously, I used
I am currently stuck with this solution; I would like to know if using the get() explicitly column struct member method is possible. I was trying to implement such an approach, but there is a type problem; the member method pointer type is ex. I would like to know if you think such a performance difference would be acceptable and if you can think of a more efficient solution. |
@mytkom thank you for your work. See inline comments. I might have more once those are resolved. |
Please consider the following formatting changes to AliceO2Group#13498
@ktf |
Please consider the following formatting changes to AliceO2Group#13498
@ktf |
Please consider the following formatting changes to AliceO2Group#13498
Error while checking build/O2/fullCI for 6e55f8d at 2024-10-21 18:16:
Full log here. |
962a8d2
to
6861013
Compare
@ktf I have rebased PR, and now all checks are successful. |
Thank you for following this through. Merging this. Could you please move the helper functions which are only internal into an anonymous namespace? |
I will continue our discussion here @ktf, @jgrosseo, @saganatt.
@jgrosseo was correct; this solution shouldn't be implemented as it is. It was slower in this benchmark by 3-10 times for simple examples. I will leave this draft PR here and try to implement this alternative solution I was writing about in AliceO2Group/O2Physics#7371. That 20% I was speaking of during the presentation was the whole task performance difference locally on my laptop. These are my local benchmark results: