Skip to content

Commit

Permalink
Revert "DPL Analysis: re-enable prefetching (#13559)" (#13566)
Browse files Browse the repository at this point in the history
  • Loading branch information
ktf authored Oct 4, 2024
1 parent 362c300 commit 23360e9
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions Framework/Core/src/TableTreeHelpers.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -547,14 +547,14 @@ void TreeToTable::addAllColumns(TTree* tree, std::vector<std::string>&& names)
if (mBranchReaders.empty()) {
throw runtime_error("No columns will be read");
}
// Was affected by https://github.com/root-project/root/issues/8962
// Re-enabling this seems to cut the number of IOPS in half
tree->SetCacheSize(25000000);
tree->SetClusterPrefetch(true);
for (auto& reader : mBranchReaders) {
tree->AddBranchToCache(reader->branch());
}
tree->StopCacheLearningPhase();
//tree->SetCacheSize(50000000);
// FIXME: see https://github.com/root-project/root/issues/8962 and enable
// again once fixed.
//tree->SetClusterPrefetch(true);
//for (auto& reader : mBranchReaders) {
// tree->AddBranchToCache(reader->branch());
//}
//tree->StopCacheLearningPhase();
}

void TreeToTable::setLabel(const char* label)
Expand Down

0 comments on commit 23360e9

Please sign in to comment.