Preparation for SDL3 support. #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CONFIG_SDL is now defined to the SDL major version in config.h. This should NEVER be used unless it's impossible to use SDL_VERSION_ATLEAST instead. This exists mainly for SDL3's new method of including headers (SDL3/SDL.h instead of SDL.h). * Replaced SDL_SysWMinfo_GetWND with SDL_GetWindowProperty_HWND to isolate the related SDL_SysWMinfo usage inside of compat_sdl.h. * Removed SDL_SysWMmsg_GetXEvent as it was only used in the X11 clipboard handler. The SDL_syswm.h functionality in the X11 clipboard handler is difficult to generalize in non-SDL_syswm.h terms for compat_sdl.h, so it's been left in place. * Separated all SDL code in the X11 clipboard handler from the X11 code to make it easier to write the corresponding SDL3 functions.
AliceLR
force-pushed
the
sdl3-prep-2
branch
2 times, most recently
from
3e07841 to
0c212e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes due to how SDL3 includes its headers:
CONFIG_SDLis now defined to be explicitly the major version number of SDL.Changes due to the removal of SDL_syswm.h:
SDL_SysWMinfo_GetWNDhas been replaced withSDL_GetWindowProperty_HWND, which now performs all SDL_syswm.h functionality internally. In SDL3 this is done by instead callingSDL_GetProperty(SDL_GetWindowProperties(window), ...).SDL_SysWMmsg_GetXEventhas been removed entirely. This functionality has been integrated into the X11 clipboard handler instead.