To do feature added #258
To do feature added #258
Conversation
|
please review... |
ravikr126
added
enhancement
Todo.html
Outdated
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <!-- <title>Todo App JavaScript--> |
There was a problem hiding this comment.
Keep the header as TODO List
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.15.3/css/all.min.css"/> | ||
| </head> | ||
| <body> | ||
| <div class="wrapper"> |
There was a problem hiding this comment.
Use bootstrap container instead of writing whole new styles for the wrapper.
| <body> | ||
| <div class="wrapper"> | ||
| <header>Todo App</header> | ||
| <div class="inputField"> |
There was a problem hiding this comment.
Use bootstrap form styles.
| <button>Clear All</button> | ||
| </div> | ||
| </div> | ||
|
|
There was a problem hiding this comment.
Keep the footer that is present on the home page.
| </head> | ||
| <body> | ||
| <div class="wrapper"> | ||
| <header>Todo App</header> |
There was a problem hiding this comment.
Add the navbar that is present on the home page.
| height: 100vh; | ||
| /* overflow: hidden; */ | ||
| padding: 10px; | ||
| background: linear-gradient(to bottom, #68EACC 0%, #497BE8 100%); |
There was a problem hiding this comment.
Pick colours from the existing scheme, this gradient looks far off.
| //if the user value isn't only spaces | ||
| addBtn.classList.add("active"); //active the add button | ||
| } else { | ||
| addBtn.classList.remove("active"); //unactive the add button |
There was a problem hiding this comment.
Try adding the disabled bootstrap class so the cursor also gets changed.
js/todo.js
Outdated
| addBtn.onclick = () => { | ||
| //when user click on plus icon button | ||
| let userEnteredValue = inputBox.value; //getting input field value | ||
| let getLocalStorageData = localStorage.getItem("New Todo"); //getting localstorage |
There was a problem hiding this comment.
Make the key more unique something like algo-phantoms-todo-list
|
Few requested changes are missing. @ShambhaviSharma0110 |
Description
Please include a summary of the change and which issue is fixed.
Fixes #190
Have added 3 separate files of HTML,CSS, and js and have integrated them under the more dropdown section in the navbar.
List any dependencies that are required for this change
none
Type of change
How Has This Been Tested?
UI /UX changes
Attach gif or screenshot for changes.
- After :
Checklist: