Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the social-sidebar overlaping in smaller devices and styled the DSA roadmap page. #185

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

abstrxtInfinity
Copy link

@abstrxtInfinity abstrxtInfinity commented Mar 17, 2021

#179 issue fixed.
#183 issue fixed.

DSA.html Outdated Show resolved Hide resolved
DSA.html Outdated Show resolved Hide resolved
@Shruti3004
Copy link
Collaborator

@abstrxtInfinity please makes the requested changes

@harikesh409 harikesh409 added bug Something isn't working GSSOC21 GSSoC'21 level2 Bug Fixing, small features UI/UX UI/UX labels Mar 20, 2021
@harikesh409
Copy link
Collaborator

@abstrxtInfinity resolve the merge conflicts.

@abstrxtInfinity abstrxtInfinity changed the title fixed the social-sidebar overlaping in smaller devices fixed the social-sidebar overlaping in smaller devices and styled the DSA roadmap page. Mar 20, 2021
@abstrxtInfinity abstrxtInfinity changed the title fixed the social-sidebar overlaping in smaller devices and styled the DSA roadmap page. fixed the social-sidebar overlaping in smaller devices. Mar 20, 2021
@abstrxtInfinity abstrxtInfinity changed the title fixed the social-sidebar overlaping in smaller devices. fixed the social-sidebar overlaping in smaller devices and styled the DSA roadmap page. Mar 20, 2021
@abstrxtInfinity
Copy link
Author

@harikesh409 I have resolved the conflicts and did the changes I was asked to do.

@harikesh409
Copy link
Collaborator

image
The whole social sidebar is messed up.

@abstrxtInfinity
Copy link
Author

image
The whole social sidebar is messed up.

It works fine on my device:
SharedScreenshot

The issue might be because the website has not loaded completely on your device yet.

@harikesh409 harikesh409 linked an issue Mar 24, 2021 that may be closed by this pull request
@RahulBansal0502
Copy link
Contributor

RahulBansal0502 commented Mar 27, 2021

The DSA problems page was so simple. I want to revamp it please assign it to me @harikesh409 @ravikr126

@harikesh409 harikesh409 mentioned this pull request Mar 27, 2021
@ravikr126
Copy link
Collaborator

@abstrxtInfinity please remove conflicts and then msg me on discord.

@abstrxtInfinity
Copy link
Author

@abstrxtInfinity please remove conflicts and then msg me on discord.

conflicts resolved.

Copy link
Collaborator

@harikesh409 harikesh409 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Due to CSS errors the footer is messed up correct the mentioned errors.
    image
  • In small resolutions the typing text is being overlapped.
    image
  • Your files are not up to date with the main repo sync the changes once again.

.round-2 {
position: absolute;
top: 50%;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing of the style is missing.

margin-right:6rem;
}


}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid closing bracket.

.copyright-text {
font-size: 14px;
letter-spacing: 0.6px !important;
}


font-size: 14px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For which property are you assigning the styles?

.margin-top-mobile {
padding-top: 15px;
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary extra closing bracket.

color: #fff;
font-size: 4rem;
margin-left: 2vw;
position: absolute;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct indentations and check the styles in different resolutions as I can see that the typing text is being overlapped.

@ravikr126
Copy link
Collaborator

remove all conflicts @abstrxtInfinity

@abstrxtInfinity
Copy link
Author

@ravikr126 @harikesh409 I'm sorry I was unable to remove the conflicts on time because of some personal reasons at home ( I am infected with Covid-19). I would suggest you kindly assign someone else to remove the conflicts on my behalf.
Thank You.

@harikesh409 harikesh409 added the help wanted Extra attention is needed label May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changes requested GSSOC21 GSSoC'21 help wanted Extra attention is needed level2 Bug Fixing, small features UI/UX UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The social buttons are overlapping the content.
5 participants