Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT-24127] Added Endpoint to Calculate the Folder Size. #215

Merged

Conversation

mohit-singh4
Copy link
Contributor

Copy link
Contributor

@suneet-gupta suneet-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already done the review as part of #213 `but somehow PR was accidentally merged without Architect approval. Approving the PR based on previous comments and changes.

Copy link
Contributor

@kavitshah-gl kavitshah-gl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly address the changes.

src/main/webapp/definitions/alfresco-core.yaml Outdated Show resolved Hide resolved
src/main/webapp/definitions/alfresco-core.yaml Outdated Show resolved Hide resolved
Copy link
Member

@tpage-alfresco tpage-alfresco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had quite a few comments/suggestions.

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2024

CLA assistant check
All committers have signed the CLA.

mohit-singh4 and others added 13 commits July 31, 2024 10:20
…er endpoints to calculate & receive folder size
…er endpoints to calculate & receive folder size
…gger endpoints to calculate and retrieve folder size
…gger endpoints to calculate and retrieve folder size
…gger endpoints to calculate and retrieve folder size
…gger endpoints to calculate and retrieve folder size
…gger endpoints to calculate and retrieve folder size
…gger endpoints to calculate and retrieve folder size
…gger endpoints to calculate and retrieve folder size
…gger endpoints to calculate and retrieve folder size
@dsibilio dsibilio removed their request for review September 24, 2024 13:39
…eature/MNT-24127-AddedEndpointToCalculateTheFolderSize
Copy link
Contributor

@pzhyland pzhyland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but please focus on providing the E2E test.

Copy link
Contributor

@kavitshah-gl kavitshah-gl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@mohit-singh4 mohit-singh4 merged commit 5f41f6e into master Nov 8, 2024
11 checks passed
@mohit-singh4 mohit-singh4 deleted the feature/MNT-24127-AddedEndpointToCalculateTheFolderSize branch November 8, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants