-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT-24127] Added Endpoint to Calculate the Folder Size. #215
[MNT-24127] Added Endpoint to Calculate the Folder Size. #215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have already done the review as part of #213 `but somehow PR was accidentally merged without Architect approval. Approving the PR based on previous comments and changes.
…eature/MNT-24127-AddedEndpointToCalculateTheFolderSize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly address the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had quite a few comments/suggestions.
…er endpoints to calculate folder size
…er endpoints to calculate & receive folder size
…er endpoints to calculate & receive folder size
…er endpoints to calculate folder size
…gger endpoints to calculate and retrieve folder size
…gger endpoints to calculate and retrieve folder size
…gger endpoints to calculate and retrieve folder size
…gger endpoints to calculate and retrieve folder size
…gger endpoints to calculate and retrieve folder size
…gger endpoints to calculate and retrieve folder size
…gger endpoints to calculate and retrieve folder size
…gger endpoints to calculate and retrieve folder size
…eature/MNT-24127-AddedEndpointToCalculateTheFolderSize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but please focus on providing the E2E test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
https://hyland.atlassian.net/browse/MNT-24127