Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-5184] Show progress spinner on file navigation #10596

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nikita-web-ua
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://hyland.atlassian.net/browse/ACS-5184

What is the new behaviour?

Navigating to the next file will trigger spinner loading until the next file's data is ready to be rendered.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@AleksanderSklorz
Copy link
Contributor

Two things:

  1. If you have pdf then you can see spinner and after that loading bar. Can we show only one thing (like for example only spinner) because it seems a bit strange because spinner means that something is loading so when spinner hides then we expect that everything is loaded but then again loading bar is displayed which also suggest that something is loading?
  2. Sometimes when I'm switching to image then when spinner hides I can see empty space for a moment which looks like something is not fully loaded yet. Can we somehow resolve that?
Screen.Recording.2025-01-28.at.11.59.05.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants