OPSEXP-2877 Add alfresco-audit-storage chart #393
Conversation
| checksum/config-es: {{ include (print $.Template.BasePath "/configmap-es.yaml") $ | sha256sum }} | ||
| checksum/config-mq: {{ include (print $.Template.BasePath "/configmap-mq.yaml") $ | sha256sum }} | ||
| checksum/secret-es: {{ include (print $.Template.BasePath "/secret-es.yaml") $ | sha256sum }} | ||
| checksum/secret-mq: {{ include (print $.Template.BasePath "/secret-mq.yaml") $ | sha256sum }} |
There was a problem hiding this comment.
I would not use that as it do not fit with the approach we use widely to offer usage of exisitingConfigmap (and has other drawbacks). We've been removing it from other charts (although some are probably still around). I think we should have a consistent recommendation of using proper tools like reloader
There was a problem hiding this comment.
I think we never took a final decision on this, for me they are still worth to have because sometimes they help the end users without requiring any external tooling, so dropping them mean making life harder every time for end users.
There was a problem hiding this comment.
To me keeping them means setting expectations we can't fulfil or even trigger unwanted service restarts (including in case where someone simply doesn't pay attention to that "feature"). While if someone needs to have that feature and use a dedicated tool for that he'll have full control and knowledge of how this works and it'll work as HE configured it.
Finally if someone really wants to implement that type of service reload., he should be able to do so using annotations.
There was a problem hiding this comment.
service restarts should not really be an issue on a kubernetes environment, plus this approach is also documented on helm docs https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments
however not a big deal for me if you prefer to get rid of it
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Giovanni Toraldo <[email protected]>
Ref: OPSEXP-2877