OPSEXP-2882 Add json configmap configurable with yaml to adf chart #387
Conversation
| labels: | ||
| {{- include "alfresco-adf-app.labels" . | nindent 4 }} | ||
| data: | ||
| config.json: >- |
There was a problem hiding this comment.
not sure if we can hardcode that and if we need to add the volume mounts but I think its better if we leave volume mounts optional
There was a problem hiding this comment.
not only can we but we have to. However it should be named app.config.json IIRC
| labels: | ||
| {{- include "alfresco-adf-app.labels" . | nindent 4 }} | ||
| data: | ||
| config.json: >- |
There was a problem hiding this comment.
not only can we but we have to. However it should be named app.config.json IIRC
charts/alfresco-adf-app/values.yaml
Outdated
| @@ -78,6 +78,8 @@ volumes: [] | |||
| # -- Additional volumeMounts on the output Deployment definition | |||
| volumeMounts: [] | |||
|
|
|||
| configMap: [] | |||
There was a problem hiding this comment.
If configmap is a list then I'm not sure how this works.
Do you expect to render a json list (I think that's not the expected format)? or do you plan to have more than one confimap (in which case we'd need an iterator somewhere)?
There was a problem hiding this comment.
I was planning just to have one configmap. Whatever you put in yaml format it will be converted to json. I our case it can look like this:
configMap:
$schema: "../../../node_modules/@alfresco/adf-core/app.config.schema.json"
providers: ALL
ecmHost: "{protocol}//{hostname}{:port}"
bpmHost: "{protocol}//{hostname}{:port}"
authType: OAUTH
...
Let me change that to {}
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: {{ include "alfresco-adf-app.fullname" . }} |
There was a problem hiding this comment.
I am thinking that maybe we can hardcode the name of that configmap to make it easier for users to mount it. Not sure
There was a problem hiding this comment.
If user wants to mount his own cm I think we agreed he would:
- create his own cm
- create an extra volume for it (where he can use whatever name he wants)
- create the volume mount that goes with it
and so we would not have this configMap at all
If we agree on that, then we should document it in this chart
ref: OPSEXP-2882