ACS-8607: Create Helm chart for hxi-connector #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krdabrowski
requested review from
gionn,
alxgomz,
tpage-alfresco,
mpichura,
Pawel-608 and
pmacius
gionn
reviewed
Aug 26, 2024
| {{- end }} | ||
| ports: | ||
| - containerPort: {{ .Values.liveIngester.image.internalPort }} | ||
| resources: {{- toYaml .Values.resources | nindent 12 }} |
There was a problem hiding this comment.
let's have a .liveIngester.resources since different components should have different resources set
charts/alfresco-connector-hxi/templates/deployment-connector-hxi-live-ingester.yaml
Outdated
Show resolved
Hide resolved
charts/alfresco-connector-hxi/templates/secret-connector-hxi.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Giovanni Toraldo <[email protected]>
…xi-live-ingester.yaml Co-authored-by: Giovanni Toraldo <[email protected]>
…name and fullname
…s probe will change CI outcome
gionn
reviewed
Aug 27, 2024
| repository: | ||
| # -- URL of the Alfresco repository | ||
| url: null | ||
| existingConfigMap: |
There was a problem hiding this comment.
we probably want to add an existingSecret here to inject repository credentials
There was a problem hiding this comment.
Yes, I was working on that today - done
gionn
reviewed
Aug 29, 2024
Comment on lines
+10
to
+13
| REPOSITORY_USERNAME: {{ .Values.repository.username | default "" | b64enc | quote }} | ||
| REPOSITORY_PASSWORD: {{ .Values.repository.password | default "" | b64enc | quote }} | ||
| REPOSITORY_CLIENT_ID: {{ .Values.repository.clientId | default "" | b64enc | quote }} | ||
| REPOSITORY_CLIENT_SECRET: {{ .Values.repository.clientSecret | default "" | b64enc | quote }} |
There was a problem hiding this comment.
can we drop all of this if now we are using the version override stuff?
There was a problem hiding this comment.
There are two ways to obtain repo version, so it depends if we want to preserve the possibility to have an option? 🤔 Or we are ok with forcing admin to manually provide the version?
There was a problem hiding this comment.
Moreover these properties will be required by prediction-applier
krdabrowski
changed the title
pmacius
reviewed
Aug 30, 2024
| memory: "10Mi" | ||
| affinity: {} | ||
| predictionApplier: | ||
| enabled: true |
gionn
reviewed
Aug 30, 2024
| repository: quay.io/alfresco/alfresco-hxinsight-connector-live-ingester | ||
| tag: 1.0.0-A13 | ||
| pullPolicy: IfNotPresent | ||
| internalPort: &liveIngesterPort 80 |
gionn
reviewed
Aug 30, 2024
| repository: quay.io/alfresco/alfresco-hxinsight-connector-prediction-applier | ||
| tag: 1.0.0-A13 | ||
| pullPolicy: IfNotPresent | ||
| internalPort: &predictionApplierPort 80 |
gionn
approved these changes
Sep 2, 2024
gionn
deleted the
feature/ACS-8607-Create-Helm-chart-for-live-ingester
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hyland.atlassian.net/browse/ACS-8607