Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAE-28088 Skip tests during PR draft #811

Merged
merged 5 commits into from
Nov 11, 2024
Merged

AAE-28088 Skip tests during PR draft #811

merged 5 commits into from
Nov 11, 2024

Conversation

shsahahyland
Copy link
Contributor

@shsahahyland shsahahyland commented Nov 6, 2024 •
edited by andrea-ligios
Loading

Checklist

  • Jira Reference (also in PR title):
  • README updated after adding/changing behaviour of an action
  • Proposed version increment for release:
    • Patch (bugfix)
    • Minor (new feature)
    • Major (breaking changes)
  • External PR link where changes has been tested:

Description

AAE-28088

atchertchian
atchertchian reviewed Nov 6, 2024
View reviewed changes
Copy link
Contributor

@atchertchian atchertchian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take the habit of referencing the Jira issue in the commit message and PR title (even if this convention is not enforced in this particular repository)

.github/actions/maven-build-and-tag/action.yml Outdated Show resolved Hide resolved
.github/actions/maven-build-and-tag/action.yml Outdated Show resolved Hide resolved
.github/actions/maven-build-and-tag/action.yml Outdated Show resolved Hide resolved
@shsahahyland shsahahyland changed the title Skip tests during PR draft AAE-28088 Skip tests during PR draft Nov 7, 2024
@shsahahyland shsahahyland force-pushed the improvement/AAE-28088-skip-tests-with-pr branch from dddb6b2 to 3317205 Compare November 7, 2024 05:52
atchertchian
atchertchian previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@atchertchian atchertchian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work 👍

@shsahahyland shsahahyland marked this pull request as ready for review November 7, 2024 12:12
@shsahahyland shsahahyland requested a review from a team as a code owner November 7, 2024 12:12
andrea-ligios
andrea-ligios reviewed Nov 7, 2024
View reviewed changes
docs/README.md Outdated Show resolved Hide resolved
atchertchian
atchertchian previously approved these changes Nov 7, 2024
View reviewed changes
@shsahahyland shsahahyland force-pushed the improvement/AAE-28088-skip-tests-with-pr branch from ee43c4a to acec78d Compare November 11, 2024 10:29
@andrea-ligios andrea-ligios merged commit df9be3d into master Nov 11, 2024
7 checks passed
@andrea-ligios andrea-ligios deleted the improvement/AAE-28088-skip-tests-with-pr branch November 11, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrea-ligios andrea-ligios andrea-ligios approved these changes

@atchertchian atchertchian atchertchian left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shsahahyland @atchertchian @andrea-ligios