Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-2656 Add slack file upload composite action #808

Merged
merged 12 commits into from
Nov 6, 2024

Conversation

gionn
Copy link
Member

@gionn gionn commented Nov 5, 2024

Checklist

  • Jira Reference (also in PR title): OPSEXP-2656
  • README updated after adding/changing behaviour of an action
  • Proposed version increment for release:
    • Patch (bugfix)
    • Minor (new feature)
    • Major (breaking changes)
  • External PR link where changes has been tested: license-generator#19

Description

In the past we adopted adrey/slack-file-upload-action but it's currently unmaintained:

There is now a pletora of low stars forks, all made as javascript action which are hard to inspect from the security point of view, e.g.:

Hence I prefer we maintain a simple composite action using the upstream slack python sdk to do the job.

@gionn gionn self-assigned this Nov 5, 2024
@gionn gionn marked this pull request as ready for review November 6, 2024 09:20
@gionn gionn requested a review from a team as a code owner November 6, 2024 09:20
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is it tested somewhere?

@gionn gionn requested review from alxgomz and pmacius November 6, 2024 16:06
@gionn gionn merged commit 59a39f5 into master Nov 6, 2024
3 checks passed
@gionn gionn deleted the OPSEXP-2656-slack-file-upload branch November 6, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants