Restore legend titles in scAdvanced integration notebook #801
+10
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jashapiro
reviewed
Nov 5, 2024
Co-authored-by: Joshua Shapiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a woopsie introduced in #800, which I caught when reviewing scAdvanced materials.
I had known this at one point but forgotten - when overriding the color scale for
plotReducedDimand friends, you need to also specify the legend title or it will default back tocolour_by.This PR adds the
nameto all such spots! I also missed a fewna.valuearguments, so I added those in too. Only the integration notebook needed these changes, since we don't override the color scale itself elsewhere.