Swap out fishpond for eds #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not convinced this is necessary either, up to you! |
sjspielman
approved these changes
Jun 5, 2024
Comment on lines
+78
to
+79
| # Temporary fix for broken(?) RSamtools package | ||
| RUN Rscript -e "install.packages('BiocManager'); BiocManager::install('Rsamtools')" |
There was a problem hiding this comment.
ooof what happened to RSamtools?
There was a problem hiding this comment.
I'm not sure... something in an interaction between the Bioc docker image, renv and Rsamtools means that the package it downloads is corrupted and fails to untar properly. Ally ran into it in her Docker image a week or so ago. I'm expecting it to be resolved at some point when things rebuild somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was wrong about AlexsLemonade/scpcaTools#277, I had originally noticed the change when remaking output files for this repo, so here I am swapping out
fishpondforedsin therenvfor this repository. This is because the function thattximportuses to speed up reading alevin files has moved toeds. By installingedswe can quiet the new warning, and get faster imports.For June 2024, I have already installed
edson the server, but that is not reflected here or in the docker image. I don't necessarily think we need to update the docker image, but we could if we wanted to by retagging the release (or adding a point update release).