Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

883 - Update the portal metadata command test to use call_command #893

Merged
merged 2 commits into from
Sep 11, 2024
Merged

883 - Update the portal metadata command test to use call_command #893

merged 2 commits into from
Sep 11, 2024

Conversation

nozomione
Copy link
Member

Issue Number

Closing #883

Purpose/Implementation Notes

Changes include:

  • Updated test_create_portal_metadata to use call_command
  • Cleaned up unused return in management/commands/create_portal_metadata

Types of changes

  • Refactor (addresses code organization and design mentioned in corresponding issue)

Functional tests

N/A

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Screenshots

N/A

@nozomione
(edit) replace command classes with call_command in test_create_porta…
8933941 
…l_metadata, and remove return statement in create_portal_metadata management command
@nozomione nozomione added the API label Sep 11, 2024
@nozomione nozomione self-assigned this Sep 11, 2024
@nozomione nozomione linked an issue Sep 11, 2024 that may be closed by this pull request
Update the portal metadata command test to use call_command #883
Closed
davidsmejia
davidsmejia approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nozomione nozomione merged commit 6fa8f5b into dev Sep 11, 2024
5 checks passed
@nozomione nozomione deleted the nozomione/883-use-call-command-in-create-portal-metadata branch September 11, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsmejia davidsmejia davidsmejia approved these changes

Assignees

@nozomione nozomione

Labels
API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the portal metadata command test to use call_command
2 participants
@nozomione @davidsmejia