Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use submitter ontology labels, if provided #559

Open
sjspielman opened this issue Nov 13, 2023 · 0 comments
Open

Use submitter ontology labels, if provided #559

sjspielman opened this issue Nov 13, 2023 · 0 comments

Comments

@sjspielman
Copy link
Member

Currently, our script to add submitter annotations only reads in the cell type labels provided by submitters, but they do have the optional choice to also include ontologies. We will need to account for this and get any ontology labels also into SCE.

Note these TODO spots:

# Check columns before proceeding for faster failing:
# TODO: WHAT IF THEY PROVIDE AN ONTOLOGY COLUMN? WE NEED TO PARSE THAT TOO. WILL NEED MORE IF BELOW.
if (!all(c("cell_barcode", "cell_type_assignment") %in% names(submitter_df))) {
stop("The submitter TSV file must contain columns `cell_barcode` and `cell_type_assignment`.")
}

# keep columns of interest
# TODO: WE NEED TO ALLOW FOR AN ONTOLOGY COLUMN
dplyr::select(
barcodes = cell_barcode,
submitter_celltype_annotation = cell_type_assignment
) |>


Noting this does not block #544 and the associated release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant