-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RRP repo doc updates and cleanup #143
Conversation
I like the |
Thanks @jashapiro, reversions incoming! One "motivation" I actually had here was keeping numbering consistent since we added a slide in the middle...and rather than changing all the numbers and maintaining those numbers over time I burned it all down.... |
Personally, I would keep them numbered. But I don't feel particularly strongly about it. |
@jashapiro Back to how it all was before after my gratuitous 🎢 but with updated numbers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All LGTM!
@Jen-OMalley I went through this and made sure everything is where it should be!
Give me a 👍 here if you agree that I got everything where it should be, and I'll go ahead and wrap this up at long last 🙃 |
Thumbs up given!👍🏻 LGTM @sjspielman! |
Stacked on #134
This PR updates some items I noticed should happen when I was reviewing #134.
There are a couple "bigger" changes I jumped the gun on a little bit, so tagging in @jashapiro to tell me if I went too far without discussing things first! Specifically, we really don't seem to use/need the
slides/*url
files, so I removed this directory and in the new README I indicate that slide links are available in the schedule directly. In addition, I renamed all the instructor notes to be in their own order of presentation.For @Jen-OMalley, any feedback on README wording (there are 2 READMEs heres!) let me know!