Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve et feeder #6

Closed
wants to merge 35 commits into from
Closed

Improve et feeder #6

wants to merge 35 commits into from

Conversation

AlexandruAntonescuKeysight
Copy link
Owner

aaaaaaaaa

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 22, 2024
View reviewed changes
et_feeder/et_feeder.cpp Outdated
{
// The usage of the logical not operator in this case is unlikely to be correct
// as the output is being used as an operator for a bit-wise and operation
if (i & !FLAGS)

Check failure

Code scanning / CodeQL

Incorrect 'not' operator usage

Usage of a logical not (!) expression as a bitwise operator.
@github-actions GitHub Actions
Copy link

MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact [email protected].
0 out of 1 committers have signed the MLCommons CLA.
❌ @AlexandruAntonescuKeysight
You can retrigger this bot by commenting recheck in this Pull Request

AlexandruAntonescuKeysight and others added 20 commits May 15, 2024 19:45
@AlexandruAntonescuKeysight
fixes is_cpu_op conversion in constructor
db779c9
@srinivas212
Merge pull request mlcommons#61 from mlcommons/pytest-converter
17d446f 
Refactor chakra_converter and Add Tests
@TaekyungHeo
Split classes from trace_link.py into separate files for improved mod…
95f2875 
…ularity
@TaekyungHeo
Install Chakra and PARAM in GH actions
8c845af
@TaekyungHeo
Refactor trace_link
f14d7d9
@TaekyungHeo
Refactor KinetoOperator
e157b98
@TaekyungHeo
Add unit tests for UniqueIdAssigner
baa6131
@TaekyungHeo
Add unit tests for KinetoOperator
05dc61d
@TaekyungHeo
Update Python version in python_lint.yml
0abe23d
@srinivas212
Merge pull request mlcommons#62 from mlcommons/pytest-trace-link
e2f0e9a 
Refactor chakra_trace_link and Add Tests
@srinivas212
Merge pull request mlcommons#60 from AlexandruAntonescuKeysight/is_cp…
0a20bf8 
…u_op_fix

fixes is_cpu_op conversion in constructor
@AlexandruAntonescuKeysight
Create codeql.yml
684b5a4
@AlexandruAntonescuKeysight
change to manual build
ee696a5
@AlexandruAntonescuKeysight
changes build step
fd90789
@AlexandruAntonescuKeysight
test
e546163
@AlexandruAntonescuKeysight
install protoc
9ecb0b2
@AlexandruAntonescuKeysight
install protoc
f46268f
@AlexandruAntonescuKeysight
fix path
aefeb30
@AlexandruAntonescuKeysight
test codeql
c584daf
@AlexandruAntonescuKeysight
revert change
8b5c609
github-advanced-security[bot]
github-advanced-security bot found potential problems May 16, 2024
View reviewed changes
tests/converter/test_pytorch_node.py
extracted_dir.mkdir()

with tarfile.open(tar_gz_file, "r:gz") as tar:
tar.extractall(path=extracted_dir)

Check failure

Code scanning / CodeQL

Arbitrary file write during tarfile extraction High test

This file extraction depends on a
potentially untrusted source
Loading
.
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandruAntonescuKeysight @TaekyungHeo @srinivas212