Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modal focus on link/image add #1346

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

35grain
Copy link

@35grain 35grain commented Dec 12, 2022

When the editor is displayed within a Bootstrap modal, for example, the additional Trumbowyg modal inputs are not focused properly. This fix appends the modal box right after the Trumbowyg box so that hierarchically it can receive focus without issues.

When the editor is displayed within a Bootstrap modal, for example, the additional Trumbowyg modal inputs are not focused properly. This fix appends the modal box right after the Trumbowyg box so that hierarchically it can receive focus without issues.
@Alex-D
Copy link
Owner

Alex-D commented Jan 16, 2023

I understand the fix, but I do not remember why it has been changed to the bottom of the body in the past :/

@Alex-D
Copy link
Owner

Alex-D commented Feb 24, 2023

Ok, after finding out, it seems like the issue and PRs were:

So, your solution is not working either since it results again in a form inside another form :/

@35grain
Copy link
Author

35grain commented Feb 25, 2023

I see. Not sure what the correct solution is then to be fair /: Perhaps adding an option for selecting the parent form element AFTER which the Input Links modal should be inserted, otherwise expect default behaviour? This way it stays within the parent modal (when necessary) and is valid HTML.

@Alex-D
Copy link
Owner

Alex-D commented Feb 27, 2023

That could be nice!
I do not think this needs an option; it can be the default :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants