Heat pump: Tests, Translation, Docstrings, Relocation #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run these to fix code style:
|
tests/conftest.py
Outdated
Comment on lines
6
to
9
| @pytest.fixture(scope="function") | ||
| def hp_5kw_24h() -> HeatPump: | ||
| """Heat pump with 5 kw heating output and 24 h prediction""" | ||
| return HeatPump(5000, 24) |
There was a problem hiding this comment.
why not put it in test_heatpump to keep the related things together?
There was a problem hiding this comment.
Thought we can place all fixture in one place. Maybe adding a subfolder fixtures inside tests which can be used for that.
michaelosthege
approved these changes
Oct 5, 2024
add type hints, improve unit tests.
Co-authored-by: Michael Osthege <[email protected]>
michaelosthege
force-pushed
the
tests/class_heatpump
branch
from
48c2e72 to
0c3c85c
Compare
michaelosthege
changed the title
drbacke
pushed a commit
that referenced
this pull request
Oct 6, 2024
* Add first unit test for heatpump COP calculation * Translate to english, add type hints, improve unit tests. * Run pre-commit * Apply suggestions from code review Co-authored-by: Michael Osthege <[email protected]> * Remove conftest file --------- Co-authored-by: Michael Osthege <[email protected]>
Lasall
pushed a commit
that referenced
this pull request
Jan 1, 2025
* Add first unit test for heatpump COP calculation * Translate to english, add type hints, improve unit tests. * Run pre-commit * Apply suggestions from code review Co-authored-by: Michael Osthege <[email protected]> * Remove conftest file --------- Co-authored-by: Michael Osthege <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heat pump class is refactored for this PR. Following things where done:
classprefix of python file