Refactored class_optimize.py #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Optimized Imports: Removed unused imports and organized them. - Refactored Code: Introduced split_individual function for clarity. - Improved Efficiency: Enhanced penalty calculation and streamlined loops. - Updated Evaluation Logic: Better handling of penalties in evaluate. - Type Hints added - fixed seed option added for automated tests - verbose comment added, default False Notes: - isfloat is only used in flask_server.py - start_hour is not used in this class
This was referenced Oct 4, 2024
Closed
|
statistically proof that the new class is as good as (the same) as the old one. |
fortrieb
requested changes
Oct 5, 2024
| start_hour, | ||
| self.prediction_hours, | ||
| einspeiseverguetung_euro_pro_wh, | ||
| extra_data=extra_data, | ||
| ) | ||
|
|
||
| os.system("cp visualisierungsergebnisse.pdf ~/") |
There was a problem hiding this comment.
Result PDF path file should be configurable, maybe a method parameter or config parameter.
| creator.create("FitnessMin", base.Fitness, weights=(-1.0,)) | ||
| creator.create("Individual", list, fitness=creator.FitnessMin) | ||
|
|
||
| # PARAMETER | ||
| # Initialize toolbox with attributes and operations | ||
| self.toolbox = base.Toolbox() |
There was a problem hiding this comment.
Initialization should be move to __init__. Toolbox is used in other places as well.
| verbose: bool = False, | ||
| fixed_seed: Optional[int] = None, | ||
| ): | ||
| """Initialize the optimization problem with the required parameters.""" |
There was a problem hiding this comment.
Docstring can be more helpful to describe each parameter. I'm using Google Style docstrings, maybe we can discuss on using in this project.
There was a problem hiding this comment.
Lets discuss this in the discussion section.
danimo
pushed a commit
that referenced
this pull request
Oct 5, 2024
Test meant for class_optimize. Will only work with PR #88 since the old class has no way to use a fixed random seed.
drbacke
pushed a commit
that referenced
this pull request
Oct 6, 2024
Test meant for class_optimize. Will only work with PR #88 since the old class has no way to use a fixed random seed.
Lasall
pushed a commit
that referenced
this pull request
Jan 1, 2025
Test meant for class_optimize. Will only work with PR #88 since the old class has no way to use a fixed random seed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: