Improve config #79
Closed
Improve config #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 stufige Optimierung, erst binär, dann mit float
PV Prognose aufsummieren der Strings eingebaut
Start ab Stunde X jetzt möglich
datetime.datetime.now() is incorrectly accessing the datetime class
- Optimized Imports: Removed unused imports and organized them. - Refactored Code: Introduced split_individual function for clarity. - Improved Efficiency: Enhanced penalty calculation and streamlined loops. - Updated Evaluation Logic: Better handling of penalties in evaluate. - Type Hints added - fixed seed option added for automated tests - verbose comment added, default False Notes: - isfloat is only used in flask_server.py - start_hour is not used in this class
…ockerfile for smaller builds
|
Please check the conflicts |
deleted comments flask_server path with os lib
removed comments fixed Bug in visualize.py (extra data empty) removed dead cp
test.py -> single_test_optimization.py
Test meant for class_optimize. Will only work with PR #88 since the old class has no way to use a fixed random seed.
* Add first unit test for heatpump COP calculation * Translate to english, add type hints, improve unit tests. * Run pre-commit * Apply suggestions from code review Co-authored-by: Michael Osthege <[email protected]> * Remove conftest file --------- Co-authored-by: Michael Osthege <[email protected]>
Dead Files
Not needed
- configuration via config.json - validation with pydantic - test loading config.json - add example config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first contribution : )
I updated the configuration handling. The configuration is now done via json file.
I tried to find all spots where the configuration is used.
This PR includes:
Sharing vscode configurations and settings
Sharing vscode settings with the suggested extension allows users to create some local settings. Project specific configuration is put in xyz.shared.json, local settings can be added in xyz.local.json. The plugin merges both files to xyz.json which is then used by vscode. This is especially helpful with launch.json.
Pydantic
With pydantic the config is type safe and the data is validated. Also it improves the workflow a lot when you can directly access the config attributes.