Cleanup: parameters: extra=forbid, optimize: battery, inverter optional #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Lasall
commented
Jan 9, 2025
Lasall
commented
- Don't allow extra fields for parameters (at least for now while changing API).
- Allow both battery and inverter to be set optionally (atm optional battery not implemented, no API constraints).
- inverter: Remove default max_power_wh
- single_test_optimization: Add more cli-parameters
- Docker: Fix entrypoint
b0661
reviewed
Jan 10, 2025
src/akkudoktoreos/core/pydantic.py
Outdated
Comment on lines
38
to
41
| class ParametersBaseModel(BaseModel): | ||
| model_config = ConfigDict(extra="forbid") | ||
|
|
||
|
|
There was a problem hiding this comment.
If this only holds for optimization parameters, please move to optimization/optimizationabc.py and call it OptimizationParametersBase. If only for devices do likewise. Why do you use BaseModel? The custom PydanticBaseModel supports several custom types that are not supported by BaseModel.
There was a problem hiding this comment.
It's basically for all REST-API related interfaces (e.g. parameters), I'm open for a better name.
Lasall
force-pushed
the
dl_dev-little-fixes
branch
2 times, most recently
from
270fabf to
4bcfbcc
Compare
NormannK
approved these changes
Jan 13, 2025
* Don't allow extra fields for parameters/REST-API (at least for now while changing API). * Allow both battery and inverter to be set optionally (atm optional battery not implemented, no API constraints). * inverter: Remove default max_power_wh * single_test_optimization: Add more cli-parameters
Lasall
force-pushed
the
dl_dev-little-fixes
branch
from
2db6f94 to
7609e7f
Compare
* Secrets are not available anyway for forks.
Lasall
force-pushed
the
dl_dev-little-fixes
branch
from
184ca49 to
25d5e01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.