feature: improve price forecast #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0661
requested changes
Jan 8, 2025
| price_weighted_mean = np.ma.average(prices_of_hour_masked, weights=weights) | ||
|
|
||
| return float(price_weighted_mean) | ||
|
|
||
| @cache_in_file(with_ttl="1 hour") |
There was a problem hiding this comment.
Maybe caching can be done for a longer time as data is only updated once a day.
There was a problem hiding this comment.
the api data is only updating once a day. problem is when we set the caching to long, we can ignore that update for some time.
worst case would be updatetime+cachetime.
1h would be on the save side.
id we would know when the api update is done we could check for the current time and cache 1day
NormannK
commented
Jan 8, 2025
b0661
reviewed
Jan 8, 2025
| # return history, history2, prediction # for debug main | ||
|
|
||
|
|
||
| """ |
There was a problem hiding this comment.
Why do you make this a comment?
There was a problem hiding this comment.
I'm unable to make it run bc of mypy if i keep it in.
b0661
requested changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying elecpriceakkudoktor.py so it can hold up to 5 weeks of data.
Depending on the amount of data we will run different forecasts.
With 5 weeks we will use ets.