Replace pytz with stdlib zoneinfo/timezone, Bump python to 3.9 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelosthege
approved these changes
Oct 9, 2024
pyproject.toml
Outdated
| @@ -7,7 +7,7 @@ authors = [ | |||
| description = "This project provides a comprehensive solution for simulating and optimizing an energy system based on renewable energy sources. With a focus on photovoltaic (PV) systems, battery storage (batteries), load management (consumer requirements), heat pumps, electric vehicles, and consideration of electricity price data, this system enables forecasting and optimization of energy flow and costs over a specified period." | |||
| readme = "README.md" | |||
| license = {file = "LICENSE"} | |||
| requires-python = ">=3.8" | |||
| requires-python = ">=3.9" | |||
There was a problem hiding this comment.
#127 already required 3.10
Suggested change
| requires-python = ">=3.9" | |
| requires-python = ">=3.10" |
There was a problem hiding this comment.
the need for 3.10 #127 is not mandatory. if there any reasons against it we can remove that with a 2 line change.
There was a problem hiding this comment.
As long as that part is in the code, the project requires 3.10.
Lasall
force-pushed
the
dl_dev-drop-pytz
branch
from
85719dd to
bc844a5
Compare
* Timezone support comes with the standard lib since 3.9 * Bump to 3.10 because typing.TypeGuard
Lasall
force-pushed
the
dl_dev-drop-pytz
branch
from
bc844a5 to
6c9dbaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unlisted dependency pytz. If we want to keep it (comes as transitive dep atm), then we should put it into requirements.txt.