also sync segment name through udp

[Liliputech]

This commit solves this issue : #4468

[netmindz]

Should this be an optional sync attribute, like the existing ones are?

[Liliputech]

as of now its not optional but I can make it optional if needed.
I was not sure in which category to add this (effects, segment bounds, options?), or if I should create a new category.
The name sometime is used by the effect for the effect configuration (see GIF image branch).

[blazoncek]

This is a breaking change. Old devices may crash or behave incorrectly due to message containing unexpected content.
Please rework so older devices will behave correctly.

[Liliputech]

This is to be tested but since the "segment packet size" is sent in the UDP packet and read by the receiver it may be backward compatible.

[netmindz]

I'd suggest a new checkbox called Segment Name

[Liliputech]

Ok, I'll work on this and will push some new commits to reflect this change

[Liliputech]

one new commit is available with option to enable or disable segment name sync (disabled by default like Segment Options).

[netmindz]

What testing have you done so far with regards to @blazoncek 's comments about compatibility testing between systems using your new packet format and without?

[Liliputech]

Unfortunately didn't had the opportunity to run such tests yet. I will do ASAP
My idea of how to test this : flash one board with my branch and another board with main branch without packet format change.
then enable sync on both boards and see if everything is fine (color/segment options change).
Also see change the segment name on the board with my branch, trigger an update and see if the other board don't crash.

[netmindz]

Unfortunately didn't had the opportunity to run such tests yet. I will do ASAP My idea of how to test this : flash one board with my branch and another board with main branch without packet format change. then enable sync on both boards and see if everything is fine (color/segment options change). Also see change the segment name on the board with my branch, trigger an update and see if the other board don't crash.

When you mean sync on both, do you mean making one the sender and one the receiver and then doing the same the other way round? We need to ensure we cover both "forward" and "backwards" compatibility