Correct completion menu current item color styling #2980
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
completion-menu-current-color
andcompletion-menu-current-bg-color
properties were incorrectly applied.Previously:
completion-menu-current-color
was setting the background colorcompletion-menu-current-bg-color
was setting the text colorThis was backwards from the expected behavior and from how prompt_toolkit's default styling works (where
fg
sets text color andbg
sets background color).The fix
completion-menu-current-color
now properly sets the text colorcompletion-menu-current-bg-color
now properly sets the background colorThis matches prompt_toolkit's default styling pattern seen in defaults.py:
Now when using:
completion-menu-current-color: blue
completion-menu-current-bg-color: red
The selected completion item will show:
This provides more intuitive color configuration and matches the expected styling behavior.