Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed peer-reviewed to reviewStatus #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed peer-reviewed to reviewStatus #23

wants to merge 1 commit into from

Conversation

alanorth
Copy link
Collaborator

The behaviour of the element is the same: use boolean true if reviewed. Replaces #20. Pending discussion in #14:

  • Should we use a controlled list for values like on CGSpace (Internal Review, Peer Review)?
  • Should we rename the field to camel case like "cg.reviewStatus" to follow similar convention of other fields?

@alanorth alanorth changed the title #14 changed peer-reviewed by review-status Changed peer-reviewed to review-status Jan 21, 2020
@alanorth alanorth added the enhancement New feature or request label Jan 21, 2020
alanorth added a commit to alanorth/cg-core that referenced this pull request Jul 27, 2020
@alanorth
Use reviewStatus instead of peer-reviewed
aa29eeb 
This should indicate the type of review, if any, that a resource
has had.

Fixes AgriculturalSemantics#14. Replaces AgriculturalSemantics#23.
alanorth added a commit to alanorth/cg-core that referenced this pull request Jul 27, 2020
@alanorth
Use reviewStatus instead of peer-reviewed
6ea9f92 
This should indicate the type of review, if any, that a resource
has had.

Fixes AgriculturalSemantics#14. Replaces AgriculturalSemantics#23.
@alanorth alanorth force-pushed the review-status branch 2 times, most recently from 6ea9f92 to 4b946a1 Compare July 27, 2020 07:50
@alanorth alanorth mentioned this pull request Jul 27, 2020
Open
@alanorth alanorth changed the title Changed peer-reviewed to review-status Changed peer-reviewed to reviewStatus Feb 5, 2021
@alanorth
Use reviewStatus instead of peer-reviewed
71415a8 
This should indicate the type of review, if any, that a resource
has had.

Fixes AgriculturalSemantics#14.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alanorth