Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add files to gitignore #94

Closed
wants to merge 4 commits into from
Closed

Conversation

amessbee
Copy link
Contributor

Add the following to .gitignore:


# Yarn related
.yarnrc.yml
.yarn/install-state.gz

# contract tx
contract/,tx.json

@amessbee amessbee requested a review from rabi-siddique August 20, 2024 04:02
@amessbee
Copy link
Contributor Author

@rabi-siddique Please verify what I am doing is correct. I know contract/,tx.json needs to be added but I am not very sure about the other two files.


# Yarn related
.yarnrc.yml
.yarn/install-state.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, you should include .yarnrc.yml in your Git repo because it contains Yarn configuration specific to your project.

As for .yarn/install-state.gz, it is typically related to the installation state of your dependencies. It is generally not necessary to include it in your repository.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see these files in our repo. Are these files generated somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are created when I run the usual commands on my machines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rabi-siddique do you suggest we should add .yarnrc.yml file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we avoid adding .yarnrc.yml for now, as we might need to create a custom Yarn configuration in the future.

@amessbee amessbee force-pushed the ms/move-files-to-gitignore branch from 8124977 to a1b96a2 Compare August 23, 2024 09:35
@amessbee amessbee closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants