-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ui): ensure title and connect wallet button render #57
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
dfa1daa
test(ui): ensure title and connect wallet button render
0xpatrickdev aba2636
chore: update @agoric/rpc to a version that supports esm
0xpatrickdev 317e853
test: add ui test with puppeteer
0xpatrickdev e96cbf3
chore: update ses to 0.18.8
0xpatrickdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,3 +22,5 @@ jobs: | |
run: yarn build | ||
- name: yarn test | ||
run: yarn test | ||
- name: yarn test:e2e | ||
run: yarn test:e2e |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import './installSesLockdown'; | ||
import { render, screen } from '@testing-library/react'; | ||
import App from './App'; | ||
|
||
describe('App.tsx', () => { | ||
it('renders app title', async () => { | ||
render(<App />); | ||
|
||
const titleElement = await screen.findByText('Items Listed on Offer Up', { | ||
selector: 'h1', | ||
}); | ||
expect(titleElement).toBeTruthy(); | ||
}); | ||
|
||
it('renders the wallet connection button', async () => { | ||
render(<App />); | ||
const buttonEl = await screen.findByRole('button', { | ||
name: 'Connect Wallet', | ||
}); | ||
expect(buttonEl).toBeTruthy(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import puppeteer from 'puppeteer'; | ||
import { execSync, spawn } from 'node:child_process'; | ||
|
||
describe('Puppeteer E2E test', () => { | ||
it('should load the webpage', async () => { | ||
execSync('yarn build'); | ||
const previewServer = spawn('yarn', ['preview'], { | ||
detached: true, | ||
stdio: 'ignore', | ||
}); | ||
// delay for preview server to start | ||
await new Promise(resolve => setTimeout(resolve, 2000)); | ||
|
||
try { | ||
const browser = await puppeteer.launch(); | ||
const page = await browser.newPage(); | ||
await page.goto('http://localhost:4173'); | ||
|
||
const buttonText = await page.$eval('button', el => el.textContent); | ||
expect(buttonText).toBe('Connect Wallet'); | ||
|
||
await browser.close(); | ||
previewServer.kill(); | ||
} catch (_) { | ||
previewServer.kill(); | ||
} | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,16 @@ | ||
/// <reference types="vitest" /> | ||
|
||
import { defineConfig } from 'vite'; | ||
import react from '@vitejs/plugin-react'; | ||
|
||
// https://vitejs.dev/config/ | ||
export default defineConfig({ | ||
plugins: [react()], | ||
test: { | ||
globals: true, | ||
environment: 'happy-dom', | ||
testTimeout: 20000, // 20 seconds for puppeteer CI | ||
// modified import('vitest/dist/config.js').defaultInclude | ||
include: '**/*.{spec,e2e}.?(c|m)[jt]s?(x)', | ||
}, | ||
}); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm. Let's not forget that dapp-offer-up is supposed to be simple. I'm a little afraid that readers are going to get overwhelmed by some of this stuff. On the other hand, it's the only sane way to be sure we're not breaking things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points. In d3b726c I moved the test to
/test
so it's less prominent. Also have it only running onyarn test:e2e
, instead ofyarn test
.Maybe this sort of test is best for a
react-scripts
-esque library that this eventually depends on.