Zoe use watchPromises for the release branch #8710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
added
Zoe
Chris-Hibbert
changed the title
use watchPromise() to wait for contract finish; This repairs new contracts, but doesn't help existing contracts.
There was a bug in the part of the test that was attempting to run a bunch of scenarios across the upgrade. Rather than resuming each run after the upgrade, it was running the whole scenario from scratch after the upgrade.
it's not necessarily null. it's whatever the version is that's built.
Chris-Hibbert
force-pushed
the
8387-zoeProspectiveFix-rel
branch
from
308fe55
to
5ef4d84
Compare
turadg
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8453
Description
push #8453 to the release branch
Security Considerations
N/A
Scaling Considerations
N/A
Documentation Considerations
N/A
Testing Considerations
No additional testing for the release branch.
Upgrade Considerations
This is one of the main parts of upgrade 14