Skip to content

Commit

Permalink
chore(a3p-integration): do special-case in `proposals/f:*/package.jso…
Browse files Browse the repository at this point in the history
…n` (#10294)

_Incidental._

## Description

Don't use special-case `build:submissions` scripts in `a3p-integration/package.json`, instead use additional declarative proposal generation in the `proposals/*/package.json` files.

### Security Considerations

n/a

### Scaling Considerations

n/a

### Documentation Considerations

As documented in https://github.com/Agoric/agoric-sdk/blob/master/a3p-integration/README.md#generating-core-eval-submissions this approach takes advantage of the fact that the submission output relative directory is specified by the second argument in each `proposals/?:*/package.json` `"sdk-generate"` array entry.  Those entries are interpreted by the `build-all-submissions.sh` script, as executed by `cd a3p-integration && yarn build`, or more specifically, `cd a3p-integration && yarn build:submissions`.

### Testing Considerations

n/a

### Upgrade Considerations

n/a
  • Loading branch information
mergify[bot] authored Oct 20, 2024
2 parents 7b2cca2 + 8b16fd4 commit 919c173
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
4 changes: 0 additions & 4 deletions a3p-integration/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,3 @@ proposals/*/.yarn/*
!proposals/*/.yarn/releases
!proposals/*/.yarn/sdks
!proposals/*/.yarn/versions

# build artifacts
proposals/*/mainNet/*
proposals/*/devNet/*
4 changes: 1 addition & 3 deletions a3p-integration/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@
"scripts": {
"build": "yarn run build:sdk && yarn run build:submissions && yarn run build:synthetic-chain",
"build:sdk": "make -C ../packages/deployment docker-build-sdk",
"build:submissions": "scripts/build-all-submissions.sh && yarn run build:priceFeeds-for-mainnet && yarn run build:priceFeeds-for-devnet",
"build:priceFeeds-for-mainnet": "scripts/build-submission.sh proposals/f:replace-price-feeds inter-protocol/updatePriceFeeds.js submission/main main; scripts/build-submission.sh proposals/f:replace-price-feeds vats/add-auction.js submission/main; scripts/build-submission.sh proposals/f:replace-price-feeds vats/upgradeVaults.js submission/main",
"build:priceFeeds-for-devnet": "scripts/build-submission.sh proposals/f:replace-price-feeds inter-protocol/updatePriceFeeds.js submission/devnet devnet; scripts/build-submission.sh proposals/f:replace-price-feeds vats/add-auction.js submission/devnet; scripts/build-submission.sh proposals/f:replace-price-feeds vats/upgradeVaults.js submission/devnet",
"build:submissions": "scripts/build-all-submissions.sh",
"build:synthetic-chain": "yarn synthetic-chain build",
"lint": "../node_modules/.bin/eslint proposals",
"test": "yarn synthetic-chain test",
Expand Down
10 changes: 8 additions & 2 deletions a3p-integration/proposals/f:replace-price-feeds/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,14 @@
"source": "subdir",
"sdk-generate": [
"inter-protocol/updatePriceFeeds.js submission A3P_INTEGRATION",
"vats/add-auction.js",
"vats/upgradeVaults.js"
"vats/add-auction.js submission",
"vats/upgradeVaults.js submission",
"inter-protocol/updatePriceFeeds.js submission/main main",
"vats/add-auction.js submission/main",
"vats/upgradeVaults.js submission/main",
"inter-protocol/updatePriceFeeds.js submission/devnet devnet",
"vats/add-auction.js submission/devnet",
"vats/upgradeVaults.js submission/devnet"
],
"type": "/agoric.swingset.CoreEvalProposal"
},
Expand Down

0 comments on commit 919c173

Please sign in to comment.