Fix #122 by using operators that are consistent with the type of the operands

[msprotz]

No description provided.

[msprotz]

       > c.sh: line 87: git: command not found
       > c.sh: line 91: fstar.exe: command not found

@mtzguido @Nadrieril any clues?

[msprotz]

-        "rev": "a3be6122b76ec0ca29030e1ff72576dceeede19d",
+        "rev": "db2cbe786566325e6d0ea96c113a294ab2a1c8c0",

is what F* moved to

[Nadrieril]

These two messages have been here for a while actually it seems, e.g. on this previous successful run. The real error seems to be:

       > Bundling creates a dependency cycle:
       > libcrux_ml_kem.sampling.sample_from_xof_b3 (found in file libcrux_mlkem_avx2) mentions libcrux_ml_kem.hash_functions.portable.PortableHash_44 (found in file libcrux_mlkem_portable)
       > tuple_dd (found in file libcrux_mlkem_portable) mentions libcrux_ml_kem.polynomial.PolynomialRingElement_f6 (found in file libcrux_mlkem_avx2)
       > libcrux_ml_kem.ind_cca.instantiations.portable.validate_public_key_6b (found in file libcrux_mlkem1024_portable) mentions libcrux_ml_kem.ind_cca.validate_public_key_00 (found in file libcrux_mlkem_portable)
       > Fatal error: exception Krml.Warn.Fatal("Unrecoverable error")

[Nadrieril]

cryspen/libcrux#735 will fix these two confusing errors (but not fix this PR).

[msprotz]

Thanks @Nadrieril I got sidetrack by these errors about missing things in the PATH.

[msprotz]

I actually can see this error with the following set of revisions:

jonathan@absinthe:~/Code/libcrux/libcrux-ml-kem (main) $ git rev-parse head
31e77d0e773e3d025ffeb024f3f4742d9a2b2eec
jonathan@absinthe:~/Code/eurydice (main) $ git rev-parse head
8e112cd3065d2c1eb6c023cd37111300dbf9fc9a
jonathan@absinthe:~/Code/everest/karamel ((e111ce50...)) $ git rev-parse head
e111ce506ea7dd6da2cdd5ee476220ce61d79073

I thought circus-green was supposed to catch breakages like this?

[msprotz]

(note that the karamel commit is on branch main)

[Nadrieril]

I thought circus-green was supposed to catch breakages like this?

Hm, I tried circus-green with these commits and it fails in the expected way. Is it just that the commits were more recent than a day ago?

[msprotz]

This is the faulty PR -- FStarLang/karamel#511

[msprotz]

(from two weeks ago)

[Nadrieril]

I see, then circus-green must not be updating the commits properly. I think I know what the problem is.

[Nadrieril]

Fixed in Inria-Prosecco/circus-green#9.