Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Get multi-slice number of slices dynamically and add simulated data #318

Closed
wants to merge 17 commits into from

Conversation

carterbox
Copy link
Contributor

Purpose

Approach

Pre-Merge Checklists

Submitter

  • Write a helpfully descriptive pull request title.
  • Organize changes into logically grouped commits with descriptive commit messages.
  • Document all new functions.
  • Click 'details' on the readthedocs check to view the updated docs.
  • Write tests for new functions or explain why they are not needed.
  • Address any complaints from pep8speaks.

Reviewer

  • Actually read all of the code.
  • Run the new code yourself; the included tests should make this easy.
  • Write a summary of the changes as you understand them.
  • Thank the submitter.

@pep8speaks
Copy link

pep8speaks commented Jun 14, 2024

Hello @carterbox! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 49:81: E501 line too long (81 > 80 characters)
Line 55:81: E501 line too long (87 > 80 characters)
Line 68:81: E501 line too long (85 > 80 characters)

Comment last updated at 2024-06-25 15:35:31 UTC

@carterbox
Copy link
Contributor Author

@a4894z, singers dataset is now included in this branch

@@ -45,6 +45,48 @@ def setUp(self, filename='siemens-star-small.npz.bz2'):
)


class SingersSetup:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class implements simulated data using the singers dataset.

@carterbox carterbox changed the title DEV: Prototype multi-slice difference map REF: Get multi-slice number of slices dynamically and add simulated data Jun 25, 2024
@carterbox carterbox closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants