Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix wrong parameter name used to call smoothness_constraint #276

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

carterbox
Copy link
Contributor

@carterbox carterbox commented Aug 1, 2023

Purpose

Fix a runtime error where the wrong keyword is used for a parameter of the smoothness_constraint function.

Approach

Use 'a' instead of 'r'.

Pre-Merge Checklists

Submitter

  • Write a helpfully descriptive pull request title.
  • Organize changes into logically grouped commits with descriptive commit messages.
  • Document all new functions.
  • Click 'details' on the readthedocs check to view the updated docs.
  • Write tests for new functions or explain why they are not needed.
  • Address any complaints from pep8speaks.

Reviewer

  • Actually read all of the code.
  • Run the new code yourself; the included tests should make this easy.
  • Write a summary of the changes as you understand them.
  • Thank the submitter.

@carterbox carterbox marked this pull request as ready for review August 1, 2023 20:40
@carterbox carterbox merged commit 095125f into main Aug 1, 2023
6 checks passed
@carterbox carterbox deleted the bug-wrong-parameter-name branch August 1, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant