REF: Actually copy parameters / Update convergence metric #275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Actually return a copy of the parameters classes when using the copy_to_device/copy_to_host functions. This prevents unexpected behavior when a parameter of one of these classes is modified in place.
Use a convergence metric that checks how much (absolutely) the object has changed since the last epoch.
Approach
Return a new instance of the Parameter classes from the copy_to functions instead of a reference to the original.
Pre-Merge Checklists
Submitter
Reviewer